Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

CloudBuildSource should not have Topic in its spec #1211

Closed
nachocano opened this issue Jun 4, 2020 · 1 comment · Fixed by #1264
Closed

CloudBuildSource should not have Topic in its spec #1211

nachocano opened this issue Jun 4, 2020 · 1 comment · Fixed by #1264
Assignees
@capri-xiyue
Labels
area/sources kind/feature-request New feature or request priority/1 Blocks current release defined by release/* label or blocks current milestone release/2
Milestone
v0.16.0-M2

Comments

@nachocano
Copy link
Member

Problem
The CloudBuildSource should not have topic in its spec as it is not configurable. It will always be the same value cloud-builds. Users cannot use some other topic, that is just how CloudBuild works.

Persona:
Developer

Exit Criteria
Remove it when we promote the Source to v1beta1
@nachocano nachocano added the kind/feature-request New feature or request label Jun 4, 2020
@nachocano
Copy link
Member Author

We are also missing the dataschema

@grantr grantr added priority/1 Blocks current release defined by release/* label or blocks current milestone release/2 labels Jun 9, 2020
@grantr grantr added this to the Backlog milestone Jun 9, 2020
@nachocano nachocano mentioned this issue Jun 11, 2020
Merged
@nachocano nachocano modified the milestones: Backlog, v0.16.0-M2 Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@capri-xiyue capri-xiyue

Labels
area/sources kind/feature-request New feature or request priority/1 Blocks current release defined by release/* label or blocks current milestone release/2
Projects
None yet
Milestone
v0.16.0-M2
Development

Successfully merging a pull request may close this issue.

changed reconciler, UT and e2e to be v1beta1 capri-xiyue/knative-gcp
3 participants
@grantr @nachocano @capri-xiyue