Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility #335

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Python 3 compatibility #335

merged 1 commit into from
Aug 8, 2017

Conversation

benley
Copy link
Contributor

@benley benley commented Aug 7, 2017

Fixes #26, #330

@benley
Copy link
Contributor Author

benley commented Aug 7, 2017

The one part I'm not sure about in this change is the m_size field in the PyModuleDef _jsonnet struct. Does this module keep internal state in a way that requires an allocation there?

@benley benley mentioned this pull request Aug 7, 2017
8 tasks
@sparkprime
Copy link
Collaborator

m_size == -1 should be OK because all of the state is built up and torn down within the single evaluate call.

Thanks for doing this!

@sparkprime sparkprime closed this Aug 7, 2017
@ant31
Copy link

ant31 commented Aug 8, 2017

is it merged ?

@benley
Copy link
Contributor Author

benley commented Aug 8, 2017

I was wondering that too - maybe the merge happened in piper and we're waiting for MOE or copybara (or something) to run and publish the result back to github?

@sparkprime sparkprime reopened this Aug 8, 2017
@sparkprime sparkprime merged commit 51d657d into google:master Aug 8, 2017
@benley benley deleted the python-3 branch August 8, 2017 22:41
@sparkprime
Copy link
Collaborator

I'm afraid the explanation was more simple than that :) Sorry

@benley
Copy link
Contributor Author

benley commented Aug 8, 2017

No worries - thanks for merging :-D

@wiseman
Copy link

wiseman commented Aug 25, 2017

Thanks for doing this work!

Is there an ETA for a new pypi release with support for Python 3?

@sparkprime
Copy link
Collaborator

No plan just yet, if you need it make a bug and we'll figure out if there's anything we should wait for vs just cut it then and there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants