Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.x Compatibility #26

Closed
laurayco opened this issue Nov 21, 2014 · 5 comments
Closed

Python 3.x Compatibility #26

laurayco opened this issue Nov 21, 2014 · 5 comments

Comments

@laurayco
Copy link

I forked and converted to use Visual Studio, and I also changed support from Python 2 C API to Python 3.4 API. It wasn't horribly difficult to do either task, but the project is there for anybody who needs or wants it.

@sparkprime
Copy link
Collaborator

Cool! Did you change any of the code or is it just directory structure & build files?

@laurayco
Copy link
Author

If I remember correctly, the only source file I changed was _jsonnet.c which I changed from 2.x compatibility to 3.x compatibility ( rather than using #defines for both ).

@wiseman
Copy link

wiseman commented Jul 20, 2017

Would this project accept a pull request that made jsonnet compatible with both Python 2 and Python 3?

@sparkprime
Copy link
Collaborator

Yes, please submit a PR to google/jsonnet with the changes to _jsonnet.c. How does this work, do we distribute it via a separate pypy package?

@benley
Copy link
Contributor

benley commented Aug 7, 2017

I had a go at a hybrid python2/python3 module with a bunch of #ifdefs. It should not require a separate pypi package, since jsonnet is distributed as a source tarball there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants