Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused files #1654

Merged
merged 3 commits into from
Mar 2, 2020
Merged

Conversation

Marcono1234
Copy link
Collaborator

It appears gson/docs/javadocs has been generated and its content is not used anymore, but please let me know if this is incorrect.

@inder123
Copy link
Collaborator

Thank you for the change. Yes, we should delete these files.
However, gson/Gson 2.1 notes.txt shouldn't be deleted.

@Marcono1234
Copy link
Collaborator Author

It appears CHANGELOG.md already covers this:

gson/CHANGELOG.md

Lines 165 to 171 in 87b1d26

## Version 2.1
_2011-12-30_ (Targeted Dec 31, 2011)
* Support for user-defined streaming type adapters
* continued performance enhancements
* Dropped support for type hierarchy instance creators. We don't expect this to be a problem. We'll also detect fewer errors where multiple type adapters can serialize the same type. With APIs like getNextTypeAdapter, this might actually be an improvement!

If not, I would suggest adding the missing information there instead. However it appears it is partially already covered and changes to a test (TypeHierarchyAdapterTest) should not be mentioned anyways.

@inder123 inder123 merged commit 360cd3e into google:master Mar 2, 2020
@Marcono1234 Marcono1234 deleted the remove-unused-files branch March 5, 2020 20:19
Marcono1234 added a commit to Marcono1234/gson that referenced this pull request Feb 17, 2021
The .gitattributes file was added to prevent GitHub detecting Gson as HTML
repository due to the included generated javadoc files. However, since
google#1654 has removed the javadoc files, the .gitattributes file is no longer
needed.
eamonnmcmanus pushed a commit that referenced this pull request Aug 7, 2022
The .gitattributes file was added to prevent GitHub detecting Gson as HTML
repository due to the included generated javadoc files. However, since
#1654 has removed the javadoc files, the .gitattributes file is no longer
needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants