Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Minor) auth.ts uses deprecated http.ServerRequest #478

Merged
merged 3 commits into from
Jan 4, 2019

Conversation

PopGoesTheWza
Copy link
Collaborator

@PopGoesTheWza PopGoesTheWza commented Jan 4, 2019

Fixes #477

  • npm run test succeeds.
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

'npm run test` had errors but they do not seem related to the changes in PR
No need to update README.md

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@PopGoesTheWza
Copy link
Collaborator Author

I have a CLA now...

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 4, 2019
@takanakahiko
Copy link
Contributor

#478 (comment)

In markdown you can check by entering x between [and] .

- [ ] no checked
- [x] checked

@PopGoesTheWza
Copy link
Collaborator Author

@takanakahiko I fixed it. Thanks.

@grant grant merged commit 97e60cf into google:master Jan 4, 2019
@grant
Copy link
Contributor

grant commented Jan 4, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants