sync #1
Merged
sync #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #467 Add any required parameters for a function as a valid JSON string. If none are supplied, the default is '[]'. I have tested it with some of my own functions that require input params and it works. - [x] ~~`npm run test` succeeds.~~ Clasp run tests are still skipped due to config errors - [x] `npm run lint` succeeds. - [x] Appropriate changes to README are included in PR.
Fixes #474 By `getScriptTypeName` returning undefined when script type is not an add-on, the message at project creation was not displayed correctly. ``` $ clasp create Created new undefined script: https://script.google.com/d/XXXXXX/edit Cloned 1 file. └─ appsscript.json ``` I fixed `getScriptTypeName` to return `type` If `type` is not add-on. ex : ``` $ clasp create Created new standalone script: https://script.google.com/d/XXXXXX/edit Cloned 1 file. └─ appsscript.json ``` - [ ] `npm run test` succeeds. - [x] `npm run lint` succeeds. - [ ] Appropriate changes to README are included in PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)
npm run testsucceeds.npm run lintsucceeds.