Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.claspignore not working at all #587

Closed
lekeope opened this issue Mar 29, 2019 · 3 comments
Closed

.claspignore not working at all #587

lekeope opened this issue Mar 29, 2019 · 3 comments

Comments

@lekeope
Copy link

lekeope commented Mar 29, 2019 •
edited
Loading

Expected Behavior

The text below written within .claspignore is supposed to ignore everything else and select sample.js for push

**/**
!sample.js

Actual Behavior

But Alas, after running clasp status on the terminal

it did not ignore the rest:

'clasp status' on terminal

"clasp status" on terminal

Still did not ignore when i pushed

Screen Shot 2019-03-29 at 6 01 52 AM

"clasp push" on terminal

Steps to Reproduce the Problem

Already given above

Specifications

  • Node version: 10.15.3
  • Clasp Version: 2.1.0
  • OS: Mac (Mojave)
@grant
Copy link
Contributor

grant commented Mar 29, 2019

Thanks for the report. Probably related to #58.

@grant grant mentioned this issue Mar 29, 2019
Merged
grant added a commit that referenced this issue Mar 29, 2019
@grant
refactor: flatten getProjectFiles (#588)
7d80c04 
Part of simplifying `getProjectFiles`.
See #587.
This was referenced Mar 29, 2019
Merged
Merged
grant added a commit that referenced this issue Apr 1, 2019
@grant
refactor: remove extra fs tree read on getProjectFiles (#590)
bb303e6 
So, clasp read the fs tree 2x before `clasp push` or `clasp status`...
This removes the extra unused read.

Simplify pushing. Part of #587.
campionfellin pushed a commit to campionfellin/clasp that referenced this issue Apr 7, 2019
@grant @campionfellin
refactor: flatten getProjectFiles (google#588)
ad690ef 
Part of simplifying `getProjectFiles`.
See google#587.
campionfellin pushed a commit to campionfellin/clasp that referenced this issue Apr 7, 2019
@grant @campionfellin
refactor: remove extra fs tree read on getProjectFiles (google#590)
a5ebe19 
So, clasp read the fs tree 2x before `clasp push` or `clasp status`...
This removes the extra unused read.

Simplify pushing. Part of google#587.
@HeavensBlade HeavensBlade mentioned this issue May 2, 2019
Closed
@PopGoesTheWza
Copy link
Collaborator

This also needs to be validated after PR #620

@PopGoesTheWza
Copy link
Collaborator

@edge-developer can you try with clasp 2.2.0 if the issue still occurs?

@grant grant closed this as completed Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed not working .claspignore
3 participants
@grant @lekeope @PopGoesTheWza