-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No way to ignore a specific file within a specifically added directory in .claspignore #58
Comments
Seeing the same behavior. |
Any updates on this bug, i am still seeing the bug in version |
I definitely can't ignore the node_modules folder either??? |
I propose to use var anymatch = require('anymatch');
var micromatch = require('micromatch');
var multimatch = require('multimatch');
anymatch(['**/**', '!**/gs/**', 'gs/genericFile.js'], 'hoge.js')
// true
anymatch(['**/**', '!**/gs/**', 'gs/genericFile.js'], 'gs/genericFile.js')
// false
anymatch(['**/**', '!**/gs/**', 'gs/genericFile.js'], 'gs/hoge.js')
// false
micromatch(['hoge.js','gs/genericFile.js','gs/hoge.js'], ['**/**', '!**/gs/**', 'gs/genericFile.js'])
// [ 'hoge.js' ] <- bad
multimatch(['hoge.js','gs/genericFile.js','gs/hoge.js'], ['**/**', '!**/gs/**', 'gs/genericFile.js'])
// [ 'hoge.js', 'gs/genericFile.js' ] EDIT :
|
@takanakahiko Sounds good! PRs welcome. |
I want to ignore gulpfile.js using .claspignore but I'm unable to do. I'm using clasp@3 |
|
PR #620 should fix this |
@napostrophe can you try with clasp 2.2.0 if the issue still occurs? |
the error still happens in clasp 2.3.0 |
@armand1m Could you please provide some context about your issue? Do you have a sample |
@grimmigenaai not sure if your issue is related to Microsoft Windows. What is the output of |
@grimmigenaai Fact is... I can trace down the change which introduced the problem to about a year ago (and I am to blame for that change) I'll try to fix it in the coming week as I refactor this part of the code. |
w00t :D/ |
@grimmigenaai (and others) can you test with the #791 unofficial release? npm uninstall -g @google/clasp && npm install -g forked-clasp
clasp --version
# should be 2.4.0 or more |
I am still experiencing this issue on version 2.4.0. I'm using a sample .claspignore file from the documentation. This has been an extremely frustrating morning to say the least. Edit (again): I reverted back from 2.4.0 to 2.3.0 and I have gotten "clasp push" working again. Every one of my files was being flagged as ignored despite the contents of .claspignore |
@jackhartnett Please clarify the status on this issue |
Issue still persists on |
I am also still seeing this issue on 2.4.1 (cannot .claspignore node_modules, which is extremely annoying) |
Should this be closed? I'm not able to replicate in |
Expected Behavior
If .claspignore contains
**/**
!**/gs/**
gs/genericFile.js
clasp should ignore everything that isn't in /gs and ignore genericFile.js
Actual Behavior
Clasp still pushes genericFile.js; pushes contents of /gs
The text was updated successfully, but these errors were encountered: