Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clasp is not ignoring folder as well as specific files with extension like *.abc #207

Closed
last-stand opened this issue Jun 1, 2018 · 3 comments

Comments

@last-stand
Copy link

last-stand commented Jun 1, 2018

(Please search existing issues before creating a new one.)

Expected Behavior

I added node_modules folder in .claspignore file and tried to run clasp push but its not working properly and showing error

Invalid value at 'files[1].type' (TYPE_ENUM), "MD"
Invalid value at 'files[2].type' (TYPE_ENUM), "MD"  

I even tried node_modules/**/*.* and node_modules/**/*.MD but no luck.

Actual Behavior

If I add a folder to .claspignore file it should ignore all folders and files in that parent folder here in this case node_modules. Or at least, it should follow node_modules/**/*.* and node_modules/**/*.MD conventions to ignore specific files.

Steps to Reproduce the Problem

  1. Setup a basic project using clasp which is using some npm packages like jasmine js.
  2. Now put node_modules in .claspignore file.
  3. Try to push the code to script.google.com using clasp push
  4. You will get errors as mentioned above.

Specifications

  • Node version (v9.10.1)
  • Version (@google/[email protected]):
  • OS (MacOS High Sierra v10.13.4)
@campionfellin
Copy link
Collaborator

Hey @last-stand , thanks for filing an issue! Can we see your .claspignore file?

My .claspignore starts with node_modules/** and that seems to work. Do you have any markdown files in your current directory that you are forgetting to ignore?

@campionfellin
Copy link
Collaborator

Also, I just noticed that you are using [email protected]. Could you upgrade to [email protected] and see if the issue still persists?

@grant
Copy link
Contributor

grant commented Jul 21, 2018

Closing in favor of #58.

@grant grant closed this as completed Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants