Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch gym dependency to gymnasium #486

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

giotherobot
Copy link

Since gym is deprecated in favor of gymnasium (see https://github.com/openai/gym?tab=readme-ov-file#important-notice) here I propose the switch, allowing both installation as alternative to keep backwards compatibilty.

This allows for use of python>=3.10, that is incompatible with gym.

Possible fix for #421.

@lebrice
Copy link
Contributor

lebrice commented Jun 3, 2024

Just a note: I think the Gym wrappers here use the gym step format, not the gymnasium step format with terminated and truncated. Perhaps these would also need to be updated, as well as the pytorch training notebook that used those wrappers.

@btaba
Copy link
Collaborator

btaba commented Jun 7, 2024

Hi @lebrice can you add gymnasium to the requirements, so that the builds pass? Thank you!

@giotherobot
Copy link
Author

The idea was to keep both the gym and gymnasium dependencies and let the user install the preferred one, I guess this needs modification of the CI to install one of the two.

Or if you prefer I can drop the gym dependency and just keep the gymnasium one.

@btaba
Copy link
Collaborator

btaba commented Jun 7, 2024

Ah ok, sorry I was misreading this. I think the right thing to do is what @lebrice is saying. Switch to gymnasium altogether and hash out differences in the API calls in brax. You can ignore brax/v1 entirely since it's deprecated. How does that sound?

@giotherobot
Copy link
Author

I can work on that, should be easier than what I was trying to do here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants