-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch gym dependency to gymnasium #486
base: main
Are you sure you want to change the base?
Conversation
Just a note: I think the Gym wrappers here use the gym step format, not the gymnasium step format with terminated and truncated. Perhaps these would also need to be updated, as well as the pytorch training notebook that used those wrappers. |
Hi @lebrice can you add gymnasium to the requirements, so that the builds pass? Thank you! |
The idea was to keep both the gym and gymnasium dependencies and let the user install the preferred one, I guess this needs modification of the CI to install one of the two. Or if you prefer I can drop the gym dependency and just keep the gymnasium one. |
Ah ok, sorry I was misreading this. I think the right thing to do is what @lebrice is saying. Switch to gymnasium altogether and hash out differences in the API calls in brax. You can ignore |
I can work on that, should be easier than what I was trying to do here! |
Since
gym
is deprecated in favor ofgymnasium
(see https://github.com/openai/gym?tab=readme-ov-file#important-notice) here I propose the switch, allowing both installation as alternative to keep backwards compatibilty.This allows for use of python>=3.10, that is incompatible with gym.
Possible fix for #421.