-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: delete angle, colour, and multiline input fields and blocks #7932
Merged
rachel-fenichel
merged 13 commits into
google:rc/v11.0.0
from
rachel-fenichel:delete_fields
Mar 13, 2024
Merged
feat!: delete angle, colour, and multiline input fields and blocks #7932
rachel-fenichel
merged 13 commits into
google:rc/v11.0.0
from
rachel-fenichel:delete_fields
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
changed the title
Delete_fields
feat!: delete angle, colour, and multiline input fields and blocks
Mar 13, 2024
github-actions
bot
added
breaking change
Used to mark a PR or issue that changes our public APIs.
PR: feature
Adds a feature
labels
Mar 13, 2024
1 task
github-actions
bot
added
breaking change
Used to mark a PR or issue that changes our public APIs.
PR: feature
Adds a feature
and removed
PR: feature
Adds a feature
breaking change
Used to mark a PR or issue that changes our public APIs.
labels
Mar 13, 2024
BeksOmega
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7226
Proposed Changes
Reason for Changes
Delete fields that have been moved to plugins, along with their associated blocks and generators.
Test Coverage
For generators: I deleted the relevant test suite from the generator test page, then ran the generator tests and executed each language's code to verify that it still works (or has no new bugs, in the case of PHP). I then read through the diff to make sure the changes made sense and committed the new generated code as the new golden file.
Re-adding serializer tests is tracked in google/blockly-samples#2237
Documentation
Tracked in #7245
Additional Information
BREAKING CHANGE: This change deletes the colour field, angle field, and multiline text input field. All three are now provided as plugins. The blocks associated with the colour field and multiline text field have been moved to the field plugins, whic now provide documentation on how to install the blocks.