Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: delete angle, colour, and multiline input fields and blocks #7932

Merged
merged 13 commits into from
Mar 13, 2024

Conversation

rachel-fenichel
Copy link
Collaborator

@rachel-fenichel rachel-fenichel commented Mar 13, 2024

The basics

The details

Resolves

Fixes #7226

Proposed Changes

  • Delete angle field and associated mocha tests from core.
  • Delete colour field and associated mocha tests from core.
  • Delete colour blocks, associated generators, and associated generator tests from core.
  • Delete multiline text field and associated mocha tests from core.
  • Delete multiline text block, associated generators, and associated generator tests from core.

Reason for Changes

Delete fields that have been moved to plugins, along with their associated blocks and generators.

Test Coverage

For generators: I deleted the relevant test suite from the generator test page, then ran the generator tests and executed each language's code to verify that it still works (or has no new bugs, in the case of PHP). I then read through the diff to make sure the changes made sense and committed the new generated code as the new golden file.

Re-adding serializer tests is tracked in google/blockly-samples#2237

Documentation

Tracked in #7245

Additional Information

BREAKING CHANGE: This change deletes the colour field, angle field, and multiline text input field. All three are now provided as plugins. The blocks associated with the colour field and multiline text field have been moved to the field plugins, whic now provide documentation on how to install the blocks.

@rachel-fenichel rachel-fenichel changed the title Delete_fields feat!: delete angle, colour, and multiline input fields and blocks Mar 13, 2024
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: feature Adds a feature labels Mar 13, 2024
@rachel-fenichel rachel-fenichel marked this pull request as ready for review March 13, 2024 19:12
@rachel-fenichel rachel-fenichel requested a review from a team as a code owner March 13, 2024 19:12
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: feature Adds a feature and removed PR: feature Adds a feature breaking change Used to mark a PR or issue that changes our public APIs. labels Mar 13, 2024
@rachel-fenichel rachel-fenichel merged commit 67c3aae into google:rc/v11.0.0 Mar 13, 2024
10 checks passed
@rachel-fenichel rachel-fenichel deleted the delete_fields branch March 14, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Used to mark a PR or issue that changes our public APIs. PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants