Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete fields that were moved to samples out of core #7226

Closed
1 task done
Tracked by #7446
BeksOmega opened this issue Jun 28, 2023 · 4 comments
Closed
1 task done
Tracked by #7446

Delete fields that were moved to samples out of core #7226

BeksOmega opened this issue Jun 28, 2023 · 4 comments
Assignees
Labels
issue: feature request Describes a new feature and why it should be added

Comments

@BeksOmega
Copy link
Collaborator

Check for duplicates

  • I have searched for similar issues before opening a new one.

Problem

To actually make Blockly smaller when compressed, we need to delete the fields that were moved into samples out of core.

Request

Delete the fields from core.

Alternatives considered

N/A

Additional context

Dependent on #7225

Issues that tracked moving the fields:
google/blockly-samples#1646
google/blockly-samples#1645
google/blockly-samples#1644

@BeksOmega BeksOmega added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member labels Jun 28, 2023
@maribethb maribethb removed the issue: triage Issues awaiting triage by a Blockly team member label Jul 5, 2023
@maribethb
Copy link
Contributor

We put this in the Q3 project, but we haven't decided if we're doing a major release yet or not this quarter. So a PR for this should not be submitted until we've confirmed we plan to do a major release as this is a breaking change.

@maribethb
Copy link
Contributor

Note google/blockly-samples#1733 needs to be fixed before this can be submitted as well.

@rachel-fenichel
Copy link
Collaborator

rachel-fenichel commented Jan 17, 2024

@rachel-fenichel
Copy link
Collaborator

We also need to validate that all of the register functions (registerMutator, registerMixin, etc) can handle registering the same extension multiple times. The desired behaviour is:

  • Check for any other functions that need to have the same behaviour
  • Check the currently registered function and ensure it matches the one attempting to be registered. If so, silently accept the registration call and do nothing. If they don’t match, emit a warning or error.
  • Update if needed

Rationale: An accepted pattern of use for fields is to unregister a field class, then register a substitute class under the same name. This allows users to install a default Blockly block but change the underlying field to one with different functionality.

Documentation: We may need to instruct users to unregister fields only after installing any blocks, so their objects are not overwritten by the built-in objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: feature request Describes a new feature and why it should be added
Projects
None yet
Development

No branches or pull requests

4 participants