-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete fields that were moved to samples out of core #7226
Comments
We put this in the Q3 project, but we haven't decided if we're doing a major release yet or not this quarter. So a PR for this should not be submitted until we've confirmed we plan to do a major release as this is a breaking change. |
Note google/blockly-samples#1733 needs to be fixed before this can be submitted as well. |
Issues to track additional work for moving block definitions into the field plugins: |
We also need to validate that all of the
Rationale: An accepted pattern of use for fields is to unregister a field class, then register a substitute class under the same name. This allows users to install a default Blockly block but change the underlying field to one with different functionality. Documentation: We may need to instruct users to unregister fields only after installing any blocks, so their objects are not overwritten by the built-in objects. |
Check for duplicates
Problem
To actually make Blockly smaller when compressed, we need to delete the fields that were moved into samples out of core.
Request
Delete the fields from core.
Alternatives considered
N/A
Additional context
Dependent on #7225
Issues that tracked moving the fields:
google/blockly-samples#1646
google/blockly-samples#1645
google/blockly-samples#1644
The text was updated successfully, but these errors were encountered: