Release dummy wheel listener on workspace dispose #7693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7674
Proposed Changes
Reason for Changes
Previously, the dummy wheel event listener added to the document as a workaround for a Safari bug was not being properly disposed of. This could potentially lead to memory leaks and unintended behavior. By storing the listener in a class member, we can ensure it is correctly removed when the workspace is disposed, thus improving the robustness and cleanliness of the code.
Test Coverage
Documentation
Additional Information
N/A