Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release wheel listener when disposing workspace. #7674

Closed
1 task done
BeksOmega opened this issue Dec 1, 2023 · 1 comment · Fixed by #7693
Closed
1 task done

Release wheel listener when disposing workspace. #7674

BeksOmega opened this issue Dec 1, 2023 · 1 comment · Fixed by #7693
Assignees
@ananta
Labels
good first issue issue: bug Describes why the code or behaviour is wrong

Comments

@BeksOmega
Copy link
Collaborator

BeksOmega commented Dec 1, 2023 •
edited
Loading

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

We have a dummy wheel listener we add to the document to work around a bug in safari. Currently this listener is not getting disposed when the workspace is disposed.

To Fix

  1. Create a class member variable to store the dummy listener.
  2. Remove the listener inside the WorkspaceSvg's dispose method.
@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong good first issue labels Dec 1, 2023
@ananta
Copy link
Contributor

ananta commented Dec 1, 2023

@BeksOmega I would love to work on this :)

@ananta ananta mentioned this issue Dec 5, 2023
Merged
1 task
ananta added a commit to ananta/blockly that referenced this issue Dec 5, 2023
@ananta
fix(workspace-svg): release dummy wheel listener on workspace dispose
5c4da68 
fix google#7674
BeksOmega pushed a commit that referenced this issue Dec 5, 2023
@ananta
fix: release dummy wheel listener on workspace dispose (#7693)
0836a1d 
fix #7674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananta ananta

Labels
good first issue issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release dummy wheel listener on workspace dispose ananta/blockly
2 participants
@ananta @BeksOmega