Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring block to front when icon clicked #7590

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

0scvr
Copy link
Contributor

@0scvr 0scvr commented Oct 13, 2023

Closes #7588

The basics

The details

Resolves

Fixes #7588

Proposed Changes

Added a call to bringBlockToFront() in doIconClick().

Reason for Changes

N/A

Test Coverage

N/A

Documentation

N/A

Additional Information

N/A

@0scvr 0scvr requested a review from a team as a code owner October 13, 2023 19:26
@0scvr 0scvr requested a review from BeksOmega October 13, 2023 19:26
@github-actions github-actions bot added the PR: fix Fixes a bug label Oct 13, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect! Thank you for the fix @0scvr =)

@BeksOmega BeksOmega merged commit 072c5f7 into google:develop Oct 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clicking an icon should bring the block to front
2 participants