-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clicking an icon should bring the block to front #7588
Comments
I'd like to work on this issue. |
I've forked the project and made the required changes, but I'm not sure how I can run blocky with my changes to see if they fix this issue. Do I need to run the deployDemo task and link my google cloud account or is there another way ? |
Hello! You can run |
Hey, Oscar! You can find all of the steps to validate a change in our documentation. Let us know if you need help with this. Thanks! |
Thanks a lot! I'll try to finish this later today. |
Closes google#7588 Signed-off-by: Oscar <[email protected]>
Closes #7588 Signed-off-by: Oscar <[email protected]>
Check for duplicates
Description
In the gesture code for handling a field click, we bring the block to the front. But for icon clicks, we don't bring the block to the front. This is unexpected.
We can fix this behavior by calling
this.bringBlockToFront()
in thedoIconClick
method. Due to #7587 this should be called before we callstartIcon.onClick()
.After making this change, you can run the reproduction steps again and ensure the block is brought to the front.
Reproduction steps
Stack trace
No response
Screenshots
Browsers
No response
The text was updated successfully, but these errors were encountered: