Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clicking an icon should bring the block to front #7588

Closed
1 task
maribethb opened this issue Oct 11, 2023 · 5 comments · Fixed by #7590
Closed
1 task

clicking an icon should bring the block to front #7588

maribethb opened this issue Oct 11, 2023 · 5 comments · Fixed by #7590
Assignees
Labels
good first issue issue: bug Describes why the code or behaviour is wrong

Comments

@maribethb
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

In the gesture code for handling a field click, we bring the block to the front. But for icon clicks, we don't bring the block to the front. This is unexpected.

We can fix this behavior by calling this.bringBlockToFront() in the doIconClick method. Due to #7587 this should be called before we call startIcon.onClick().

After making this change, you can run the reproduction steps again and ensure the block is brought to the front.

Reproduction steps

  1. Add a block with an icon to the workspace (such as the mutator gear icon).
  2. Add another block on top of that one.
  3. Click the icon.
  4. Notice how the block does not come to the front.

Stack trace

No response

Screenshots

image

Browsers

No response

@maribethb maribethb added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member good first issue labels Oct 11, 2023
@0scvr
Copy link
Contributor

0scvr commented Oct 12, 2023

I'd like to work on this issue.

@0scvr
Copy link
Contributor

0scvr commented Oct 12, 2023

I've forked the project and made the required changes, but I'm not sure how I can run blocky with my changes to see if they fix this issue. Do I need to run the deployDemo task and link my google cloud account or is there another way ?

@BeksOmega
Copy link
Collaborator

Hello! You can run npm run start from the root of your fork. This will bring up a local version of the playground where you can test your changes! Thank you for your work on this :D

@maribethb
Copy link
Contributor Author

Hey, Oscar! You can find all of the steps to validate a change in our documentation. Let us know if you need help with this. Thanks!

@0scvr
Copy link
Contributor

0scvr commented Oct 13, 2023

Hey, Oscar! You can find all of the steps to validate a change in our documentation. Let us know if you need help with this. Thanks!

Thanks a lot! I'll try to finish this later today.

0scvr added a commit to 0scvr/blockly that referenced this issue Oct 13, 2023
BeksOmega pushed a commit that referenced this issue Oct 14, 2023
@cpcallen cpcallen removed the issue: triage Issues awaiting triage by a Blockly team member label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants