Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor issues in browser tests #7493

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

The details

Resolves

Fixes some issues that I found while working on #7488.
Webdriverio v8.16 is slightly stricter about some things.

Proposed Changes

  • In undo/redo tests: use a lower case z instead of upper case, and add a standard pause after the undo.
  • In the procedure test: accept the alert to close it at the end of the test.
  • In field edit test: don't click between edits--the field editor is already open.
  • In the toolbox drag test: scroll a small amount at a time to avoid dragging the mouse outside of the browser window.

Reason for Changes

Newer webdriverio is stricter about keeping drags within the screen and not clicking on occluded elements. Keys are case sensitive, and not closing the alert works but throws a warning.

Test Coverage

These are tests!

@rachel-fenichel rachel-fenichel merged commit c3b7d42 into google:develop Sep 18, 2023
11 checks passed
@rachel-fenichel rachel-fenichel deleted the minor_browser_fixes branch September 18, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants