Merge pull request #7493 from rachel-fenichel/minor_browser_fixes

fix: minor issues in browser tests
google · Sep 18, 2023 · c3b7d42 · c3b7d42
2 parents 3806137 + cc3c0d9
commit c3b7d42
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/tests/browser/test/delete_blocks_test.js b/tests/browser/test/delete_blocks_test.js
@@ -179,7 +179,8 @@ suite('Delete blocks', function (done) {
     await this.browser.keys([Key.Backspace]);
     await this.browser.pause(PAUSE_TIME);
     // Undo
-    await this.browser.keys([Key.Ctrl, 'Z']);
+    await this.browser.keys([Key.Ctrl, 'z']);
+    await this.browser.pause(PAUSE_TIME);
     const after = (await getAllBlocks(this.browser)).length;
     chai.assert.equal(
       before,
@@ -195,10 +196,10 @@ suite('Delete blocks', function (done) {
     await this.browser.keys([Key.Backspace]);
     await this.browser.pause(PAUSE_TIME);
     // Undo
-    await this.browser.keys([Key.Ctrl, 'Z']);
+    await this.browser.keys([Key.Ctrl, 'z']);
     await this.browser.pause(PAUSE_TIME);
     // Redo
-    await this.browser.keys([Key.Ctrl, Key.Shift, 'Z']);
+    await this.browser.keys([Key.Ctrl, Key.Shift, 'z']);
     await this.browser.pause(PAUSE_TIME);
     const after = (await getAllBlocks(this.browser)).length;
     chai.assert.equal(

diff --git a/tests/browser/test/field_edits_test.js b/tests/browser/test/field_edits_test.js
@@ -45,8 +45,8 @@ async function testFieldEdits(browser, direction) {
   // Click on the field to change the value
   await numberBlock.click();
   await browser.keys([Key.Delete]);
-  await numberBlock.click();
   await browser.keys(['1093']);
+
   // Click on the workspace to exit the field editor
   const workspace = await browser.$('#blocklyDiv > div > svg.blocklySvg > g');
   await workspace.click();

diff --git a/tests/browser/test/procedure_test.js b/tests/browser/test/procedure_test.js
@@ -104,5 +104,6 @@ suite('Testing Connecting Blocks', function (done) {
     await this.browser.pause(PAUSE_TIME);
     const alertText = await this.browser.getAlertText(); // get the alert text
     chai.assert.equal(alertText, '123');
+    await this.browser.acceptAlert();
   });
 });
diff --git a/tests/browser/test/toolbox_drag_test.js b/tests/browser/test/toolbox_drag_test.js
@@ -148,8 +148,8 @@ async function openCategories(browser, categoryList, directionMultiplier) {
         const flyoutBlock = await browser.$(
           `.blocklyFlyout .blocklyBlockCanvas > g:nth-child(${3 + i * 2})`,
         );
-        if (!(await elementInBounds(browser, flyoutBlock))) {
-          await scrollFlyout(browser, 0, 500);
+        while (!(await elementInBounds(browser, flyoutBlock))) {
+          await scrollFlyout(browser, 0, 50);
         }
 
         await flyoutBlock.dragAndDrop({x: directionMultiplier * 50, y: 0});