fix: connect animation persisting #7365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Manually tested and couldn't reproduce the original issue.
I wasn't able to reproduce it even with the existing code. 🤔
If you can't either then we should check with @Plomging that your version of this PR does fix it for them.
I was able to reproduce it! It required some very rapid clicking :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7241
Proposed Changes
Changes the connect animations to use animation elements instead of animating manually using timeouts.
Reason for Changes
Consistency! Unlikely to be interupted and cause errors.
Test Coverage
Manually tested and couldn't reproduce the original issue.
Documentation
N/A
Additional Information
Based on #7242