feat: Insertion marker json deserialization 7316 #7364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshneydevansh
changed the title
|
The error - Did you forget to signal async completion? is because am I missing fields with the modified serialization/de-serialization, or maybe I have to review the dependencies. Furthermore, I have not yet conducted any testing on this, as I am seeking confirmation whether these are the potential modifications that we intended. |
BeksOmega
reviewed
Aug 8, 2023
BeksOmega
requested changes
Aug 8, 2023
I also wanted to know if we need to make any changes to the documents? |
varshneydevansh
changed the title
github-actions
bot
added
PR: feature
BeksOmega
approved these changes
Aug 9, 2023
Nope I think this change should be good! |
4 tasks
BeksOmega
pushed a commit
that referenced
this pull request
Aug 14, 2023
Don't add next block to the insertion marker when we do an insertion marker json serialization. Also, to keep consistent with the old behavior, we don't need to add input blocks for the insertion marker. And we don't need to do a full serialization here as it will just become an insertion marker. Resolves #7383 Address issues in PR #7364 Signed-off-by: Hollow Man <[email protected]>
ericblackmonGoogle
pushed a commit
that referenced
this pull request
Aug 14, 2023
Don't add next block to the insertion marker when we do an insertion marker json serialization. Also, to keep consistent with the old behavior, we don't need to add input blocks for the insertion marker. And we don't need to do a full serialization here as it will just become an insertion marker. Resolves #7383 Address issues in PR #7364 Signed-off-by: Hollow Man <[email protected]> (cherry picked from commit 18ee0ec)
This was referenced Aug 23, 2023
rachel-fenichel
added a commit
that referenced
this pull request
Aug 24, 2023
This reverts commit 8421538.
rachel-fenichel
added a commit
that referenced
this pull request
Aug 24, 2023
rachel-fenichel
added a commit
that referenced
this pull request
Aug 24, 2023
Merged
13 tasks
1 task
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Proposed Changes
Change the insertion marker
createMarkerBlockcode over to use JSON serialization and deserialization.Behavior Before Change
In Blockly's XML serialization, child blocks are represented using nested XML elements. This means that if a block has child blocks connected to it, those child blocks will be represented as nested XML elements within the XML element representing the parent block. The structure of the XML serialization mirrors the structure of the blocks in the workspace.
Behavior After Change
The JSON serialization system in Blockly does something similar, but with a JSON structure instead of XML. The structure of the serialized data, whether XML or JSON, is designed to capture the hierarchical relationships between blocks and their connections.
Reason for Changes
Insertion markers duplicate the block being dragged, and then tell the duplicate to be an insertion marker.
Currently the duplication duplicates (ha) a lot of code from the serialization system. We think this is because in the past the XML system didn't have a good way to just serialize and deserialize a single block (without children). But the JSON system does have this!
Test Coverage
Documentation
Additional Information