-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insertion previews become real blocks in v10.1.x #7383
Labels
issue: bug
Describes why the code or behaviour is wrong
Comments
HollowMan6
added
issue: bug
Describes why the code or behaviour is wrong
issue: triage
Issues awaiting triage by a Blockly team member
labels
Aug 12, 2023
This was referenced Aug 12, 2023
I have submitted the PR at #7384, ignore the reasoning here, as I had no idea what caused this at the time when I opened this issue, and this doesn't happen randomly at all. |
HollowMan6
changed the title
Insertion previews become real blocks randomly in v10.1.x
Insertion previews become real blocks in v10.1.x
Aug 12, 2023
BeksOmega
pushed a commit
that referenced
this issue
Aug 14, 2023
Don't add next block to the insertion marker when we do an insertion marker json serialization. Also, to keep consistent with the old behavior, we don't need to add input blocks for the insertion marker. And we don't need to do a full serialization here as it will just become an insertion marker. Resolves #7383 Address issues in PR #7364 Signed-off-by: Hollow Man <[email protected]>
ericblackmonGoogle
pushed a commit
that referenced
this issue
Aug 14, 2023
Don't add next block to the insertion marker when we do an insertion marker json serialization. Also, to keep consistent with the old behavior, we don't need to add input blocks for the insertion marker. And we don't need to do a full serialization here as it will just become an insertion marker. Resolves #7383 Address issues in PR #7364 Signed-off-by: Hollow Man <[email protected]> (cherry picked from commit 18ee0ec)
cpcallen
removed
the
issue: triage
Issues awaiting triage by a Blockly team member
label
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Check for duplicates
Description
As indicated in the title. A user also report this here: mit-cml/workspace-multiselect#20
As I made a Blockly version bump to my multi-select plugin yesterday. At first, I was assuming it to be some kind of issue that is specific to multi-select until I find that it also exists in the Blockly upstream just now 😅.
I also attach the reproduction steps as well as some screenshots below.
Reproduction steps
Stack trace
Screenshots
Screencast.from.2023-08-12.20-03-21.webm
Browsers
No response
The text was updated successfully, but these errors were encountered: