fix(tests): fix broken browser tests #7324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
approved these changes
Jul 24, 2023
| ); | ||
| chai.assert.equal((await getAllBlocks(browser)).length, i); | ||
| await dragNthBlockFromFlyout(browser, 'Align', 0, 250, 50 * i); | ||
| chai.assert.equal(i, (await getAllBlocks(browser)).length); |
There was a problem hiding this comment.
It should be the actual vaue and then the expecte value (swap le arguments).
There was a problem hiding this comment.
Done. My expectations were backwards!
| 50 * i | ||
| ); | ||
| chai.assert.equal((await getAllBlocks(browser)).length, i); | ||
| await dragNthBlockFromFlyout(browser, 'Align', 0, 250, 50 * i); |
There was a problem hiding this comment.
Was there a reason this needed to be switched out?
There was a problem hiding this comment.
One of the basic blocks was breaking (I think it's one that you fixed in dev-tools) and it was making testing difficult.
I want to have a different test to validate that every test block can be shown in the toolbox and dragged in, but this particular test doesn't actually care which block you use.
| @@ -182,7 +182,7 @@ suite('Disabling', function () { | |||
| 110, | |||
| 110 | |||
| ); | |||
| await connect(browser, child, 'PREVIOUS', parent, 'IF0'); | |||
There was a problem hiding this comment.
Huh, I guess this was just getting it close enough that it was working? lol
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Aug 2, 2023
The test plan specified to use a block from the Basic Blocks category of the test blocks. PR google#7324 changed the test in a way that violated the plan, albeit in aid of a good cause: the basic blocks category had become unusable due to a bug in the test blocks combined with better error checking (in PR google#7289). Since the test blocks were fixed by google/blockly-samples#1774 (and the fix published and Blockly updated by PR google#7313) this violation can be corrected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Proposed Changes
DO0instead ofIF0)Behavior Before Change
Tests worked for Beka but not for me
Behavior After Change
Hopefully tests work for everyone
Reason for Changes