fix: add compose and decompose errors to mutator icon #7289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
approved these changes
Jul 13, 2023
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Aug 2, 2023
The test plan specified to use a block from the Basic Blocks category of the test blocks. PR google#7324 changed the test in a way that violated the plan, albeit in aid of a good cause: the basic blocks category had become unusable due to a bug in the test blocks combined with better error checking (in PR google#7289). Since the test blocks were fixed by google/blockly-samples#1774 (and the fix published and Blockly updated by PR google#7313) this violation can be corrected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7288
Proposed Changes
Adds clearer error throwing to the mutator. Throws if necessary methods do not exist.
Test Coverage
N/A Can add unit tests if desired.
Documentation
N/A
Additional Information
N/A