fix: make insertion markers use new render management system #7307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
BeksOmega
force-pushed
the
fix/queue-insertion
branch
from
f0d230c
to
4268a8d
Compare
maribethb
approved these changes
Jul 26, 2023
| // Connect() also renders the insertion marker. | ||
| imConn.connect(closest); | ||
| } | ||
| // Position so that the existing block doesn't move. |
There was a problem hiding this comment.
I can see why imConn has to exist (we throw an error above if it doesn't) but don't see where we're otherwise validating that closest exists. Maybe worth keeping the check? or am i missing where we're checking?
There was a problem hiding this comment.
closest is non-nullable! It is always guaranteed to be part of the activeCandidate.
😱 😛 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes N/A
Proposed Changes
Makes is so that insertion markers use the new render management system.
Reason for Changes
Necessary for tearing out the
newold render management system.Test Coverage
Manually tested that insertion markers appear and look correct.
Documentation
N/A
Additional Information
Dependent on #7296