Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Make test imports correct and more consistent #7260

Merged
merged 3 commits into from
Jul 7, 2023
Merged

fix(tests): Make test imports correct and more consistent #7260

merged 3 commits into from
Jul 7, 2023

Commits on Jul 7, 2023

  1. fix(tests): Fix invalid import paths in mocha tests 

    This resolves the warnings generated during buildDeps by
closure-make-deps.

This commit does not attempt to address google#7224 or otherwise
rationalise the imports and usage thereof.
    @cpcallen
    cpcallen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    3dcf145 View commit details
    Browse the repository at this point in the history

  2. fix(tests): Fix failing context menu item test 

    Test appears to have been wrong: Block.prototype.getIcon is typed
as

    getIcon<T extends IIcon>(/* ... */): T | undefined

and documented as "@returns The icon with the given type if it
exists on the block, undefined otherwise."
    @cpcallen
    cpcallen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    05557ff View commit details
    Browse the repository at this point in the history

  3. refactor(tests): Clean up inconsistent usage of CommentIcon 

    Tweak the test files touched by PR google#7200 to be consistent with
existing usage of Blockly.icons.CommentIcon instead of importing
this separately.
    @cpcallen
    cpcallen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    f347cc4 View commit details
    Browse the repository at this point in the history