fix(tests): Make test import
s correct and more consistent
#7260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Resolves
Addresses the cause of #7224 being filed, though without making more than a token effort to address the issue as written.
Proposed Changes
Fix invalid
import
paths in mocha tests. This resolves the warnings generated duringbuildDeps
byclosure-make-deps
.Fix failing context menu item test:
Block.prototype.getIcon
is typed asgetIcon(/* ... */): T | undefined
and documented as "@returns The icon with the given type if it exists on the block, undefined otherwise."
Clean up inconsistent usage of
CommentIcon
in the test files touched by PR fix: Utilize getIcon instead of getCommentIcon in tests #7200 to be consistent with existing usage ofBlockly.icons.CommentIcon
instead of importing it separately.Behaviour Before Change
closure-make-deps
during buildDeps.Behaviour After Change
Reason for Changes
Better to run tests than not; better to pass than fail.
Test Coverage
Restored.
Additional Information
Still can't be sure that all mocha tests are actually being run!