fix: set flyout visbility on calling setExpanded #7199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Resolves
Fixes #7174
Proposed Changes
call
setVisible(isExpanded)
on theparentToolbox_
's flyout to update visibilityBehavior Before Change
flyout is not closed when
setExpanded(false)
is called oncollapsible_category
, contrary to expected behavior2023-06-23.01-51-08.mp4
Behavior After Change
flyout is hidden along with collapsed category
2023-06-23.01-44-01.mp4
Reason for Changes
fulfilling expected behavior in every case
Test Coverage
tested full functionality of expand/collapse by opening, switching, and unfocus clicking the flyout/collapsible regions before and after changes
Documentation
updated setExpanded` docstring