Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When calling setExpanded(false) on a collapsible toolbox category programmatically, the flyout should be closed #7174

Closed
1 task done
BeksOmega opened this issue Jun 15, 2023 · 1 comment · Fixed by #7199
Labels
issue: bug Describes why the code or behaviour is wrong size: small Bugs that can be picked up and completed in 1-3 days

Comments

@BeksOmega
Copy link
Collaborator

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

Originally reported by: https://groups.google.com/g/blockly/c/V5thY4HxQPI/m/bnlVYlzBAgAJ?utm_medium=email&utm_source=footer

If you call setExpanded(false) on a collapsible toolbox category, and one of the sub-categories is currently selected (i.e. its blocks are shown in the flyout). That flyout should be closed.

Reproduction steps

  1. Open the playground with the test blocks toolbox.
  2. Select the "Connections > Row" toolbox category
  3. Run the following code in the console Blockly.getMainWorkspace().getToolbox().getToolboxItems()[2].setExpanded(false);
  4. Observe how the category is closed but the flyout is still open.

Stack trace

N/A

Screenshots

Step 2:
Screenshot 2023-06-15 3 02 31 PM

Step 4:
Screenshot 2023-06-15 3 03 20 PM

Browsers

No response

@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Jun 15, 2023
@maribethb maribethb added size: small Bugs that can be picked up and completed in 1-3 days and removed issue: triage Issues awaiting triage by a Blockly team member labels Jun 15, 2023
@itsjayway
Copy link
Contributor

i can take a look at this one! i'll double check the guidelines and message guide for when I open a PR (saw a comment in another PR 🕵️‍♀️)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Describes why the code or behaviour is wrong size: small Bugs that can be picked up and completed in 1-3 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants