Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamic connection plugin readme #1919

Merged

Conversation

BeksOmega
Copy link
Contributor

The basics

The details

Resolves

Fixes N/A

Proposed Changes

Updates docs.

Reason for Changes

Up-to-date docs are happy =)

Test Coverage

N/A

Documentation

This is docs silly!

Additional Information

N/A

@BeksOmega BeksOmega marked this pull request as ready for review September 12, 2023 20:04
@BeksOmega BeksOmega requested a review from a team as a code owner September 12, 2023 20:04
@BeksOmega BeksOmega requested review from rachel-fenichel and removed request for a team September 12, 2023 20:04
Copy link
Collaborator

@rachel-fenichel rachel-fenichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: use backticks around block names.

@BeksOmega BeksOmega merged commit 06d82b6 into google:block-dynamic-serialization Sep 12, 2023
7 checks passed
BeksOmega added a commit that referenced this pull request Sep 14, 2023
* chore: update readme and remove warning

* chore: add backticks
BeksOmega added a commit to BeksOmega/blockly-samples that referenced this pull request Sep 19, 2023
* chore: update readme and remove warning

* chore: add backticks
BeksOmega added a commit to BeksOmega/blockly-samples that referenced this pull request Sep 19, 2023
* chore: update readme and remove warning

* chore: add backticks
BeksOmega added a commit to BeksOmega/blockly-samples that referenced this pull request Sep 28, 2023
* chore: update readme and remove warning

* chore: add backticks
BeksOmega added a commit to BeksOmega/blockly-samples that referenced this pull request Sep 28, 2023
* chore: update readme and remove warning

* chore: add backticks
BeksOmega added a commit that referenced this pull request Sep 28, 2023
* chore: update readme and remove warning

* chore: add backticks
BeksOmega added a commit that referenced this pull request Sep 28, 2023
* fix: upgrade keyboard navigation to use new clipboard API (#1844)

* fix: upgrade keyboard navigation to use new clipboard API

* chore: reorganize test suites

* chore: fixup delete tests

* chore: work on fixing copy tests

* chore: finish fixing up copy tests

* chore: fix cut and paste tests

* chore: delete paste suite

* chore: delete unnecessary test helpers

* chore: fixup other tests

* chore: document why we're stubbing cancelAnimationFrame and add it to teardown

* fix: upgrade cross tab copy paste to use new clipboard API (#1845)

* fix: upgrade cross tab copy paste to use new clipboard API

* chore: update to beta

* fix: upgrade shareable procedures for new clipboard API (#1863)

* chore: fix tests

* fix: upgrade the shareable procedure blocks to use the new clipboard system

* chore: update blockly version

* chore: fix lint

* fix: serialization of dynamic if blocks (#1880)

* fix: normalize inputs

* fix: work on fixing serialization

* chore: remove inputCounts

* chore: fix tests

* fix: infinite loop

* fix: serialization of dynamic list blocks (#1885)

* fix: normalize inputs

* fix: serialization

* chore: remove inputCounter

* fix: normalize connections from load

* chore: switch tests to regexp

* chore: refactor tests

* fix: rebuilding behavior

* chore: revert changes to playground

* chore: format

* fix: fully tear down dynamic block before rebuilding (#1886)

* fix: dynamic text serialization (#1887)

* fix: normalize inputs

* fix: serialization

* chore: remove inputCounter

* fix: normalize connections from load

* chore: switch tests to regexp

* chore: refactor tests

* feat: dynamic json serialization (#1888)

* feat: add json serialization for text and list dynamic blocks

* chore: use helpers to append inputs

* chore: add json serialization to if blocks

* fix: support loading stringified XML from JSOn

* fix: dynamic connection plugin readme (#1919)

* chore: update readme and remove warning

* chore: add backticks

* deprecate: edit row separator readme to deprecate it (#1920)

* chore: edit row separator readme to deprecate it.

* Mark deprecated package private to stop publishing

* fix: unnamed callers for shareable procedures (#1983)

* fix: rendering dynamic connections (#1984)

* fix: migrating json for dynamic connections (#1985)

* chore: get tests to fail

* fix: round tripping old json to new json

* chore: fixup fixes

* chore: give up on getting tests to fail properly

* fix: fixup keyboard nav to remove blockly version check (#1991)

* fix: fixup keyboard nav to remove check

* chore: update beta version

* fix: bump blockly to v10.2.0

---------

Co-authored-by: John Nesky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants