fix: upgrade shareable procedures for new clipboard API #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
fix/upgrade-shareable-for-clipboard
branch
from
9b339e4
to
2f56273
Compare
BeksOmega
requested review from
rachel-fenichel
and removed request for
a team
| 'paramId': p.getId(), | ||
| }; | ||
| }); | ||
| } | ||
| } | ||
| if (!this.hasStatements_) { |
There was a problem hiding this comment.
Why do you only need to set this when hasStatements_ is false, rather than always?
There was a problem hiding this comment.
Default is true. We always skip serialization of defaults (or we try to anyways) because it keeps the save file size smaller. E.g. we also don't serialize a 'params' array if the procedure has no params.
| const procedureId = state['procedureId']; | ||
| if (procedureId && procedureId != this.model_.getId() && | ||
| map.has(procedureId) && | ||
| (this.isInsertionMarker() || |
There was a problem hiding this comment.
Why do you no longer have to check whether it's an insertion marker?
There was a problem hiding this comment.
Insertion markers are saved with doFullSerialization: false so it is covered by the other check.
rachel-fenichel
approved these changes
Aug 16, 2023
BeksOmega
added a commit
to BeksOmega/blockly-samples
that referenced
this pull request
Sep 7, 2023
* chore: fix tests * fix: upgrade the shareable procedure blocks to use the new clipboard system * chore: update blockly version * chore: fix lint
BeksOmega
added a commit
to BeksOmega/blockly-samples
that referenced
this pull request
Sep 19, 2023
* chore: fix tests * fix: upgrade the shareable procedure blocks to use the new clipboard system * chore: update blockly version * chore: fix lint
BeksOmega
added a commit
to BeksOmega/blockly-samples
that referenced
this pull request
Sep 19, 2023
* chore: fix tests * fix: upgrade the shareable procedure blocks to use the new clipboard system * chore: update blockly version * chore: fix lint
BeksOmega
added a commit
to BeksOmega/blockly-samples
that referenced
this pull request
Sep 28, 2023
* chore: fix tests * fix: upgrade the shareable procedure blocks to use the new clipboard system * chore: update blockly version * chore: fix lint
BeksOmega
added a commit
to BeksOmega/blockly-samples
that referenced
this pull request
Sep 28, 2023
* chore: fix tests * fix: upgrade the shareable procedure blocks to use the new clipboard system * chore: update blockly version * chore: fix lint
BeksOmega
added a commit
that referenced
this pull request
Sep 28, 2023
* chore: fix tests * fix: upgrade the shareable procedure blocks to use the new clipboard system * chore: update blockly version * chore: fix lint
BeksOmega
added a commit
that referenced
this pull request
Sep 28, 2023
* fix: upgrade keyboard navigation to use new clipboard API (#1844) * fix: upgrade keyboard navigation to use new clipboard API * chore: reorganize test suites * chore: fixup delete tests * chore: work on fixing copy tests * chore: finish fixing up copy tests * chore: fix cut and paste tests * chore: delete paste suite * chore: delete unnecessary test helpers * chore: fixup other tests * chore: document why we're stubbing cancelAnimationFrame and add it to teardown * fix: upgrade cross tab copy paste to use new clipboard API (#1845) * fix: upgrade cross tab copy paste to use new clipboard API * chore: update to beta * fix: upgrade shareable procedures for new clipboard API (#1863) * chore: fix tests * fix: upgrade the shareable procedure blocks to use the new clipboard system * chore: update blockly version * chore: fix lint * fix: serialization of dynamic if blocks (#1880) * fix: normalize inputs * fix: work on fixing serialization * chore: remove inputCounts * chore: fix tests * fix: infinite loop * fix: serialization of dynamic list blocks (#1885) * fix: normalize inputs * fix: serialization * chore: remove inputCounter * fix: normalize connections from load * chore: switch tests to regexp * chore: refactor tests * fix: rebuilding behavior * chore: revert changes to playground * chore: format * fix: fully tear down dynamic block before rebuilding (#1886) * fix: dynamic text serialization (#1887) * fix: normalize inputs * fix: serialization * chore: remove inputCounter * fix: normalize connections from load * chore: switch tests to regexp * chore: refactor tests * feat: dynamic json serialization (#1888) * feat: add json serialization for text and list dynamic blocks * chore: use helpers to append inputs * chore: add json serialization to if blocks * fix: support loading stringified XML from JSOn * fix: dynamic connection plugin readme (#1919) * chore: update readme and remove warning * chore: add backticks * deprecate: edit row separator readme to deprecate it (#1920) * chore: edit row separator readme to deprecate it. * Mark deprecated package private to stop publishing * fix: unnamed callers for shareable procedures (#1983) * fix: rendering dynamic connections (#1984) * fix: migrating json for dynamic connections (#1985) * chore: get tests to fail * fix: round tripping old json to new json * chore: fixup fixes * chore: give up on getting tests to fail properly * fix: fixup keyboard nav to remove blockly version check (#1991) * fix: fixup keyboard nav to remove check * chore: update beta version * fix: bump blockly to v10.2.0 --------- Co-authored-by: John Nesky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1838
Closes google/blockly#6846
Upgrades the shareable procedures plugin to use the new
doFullSerializationparameter.