Bump com.google.testing.compile:compile-testing from 0.21.0 to 0.22.0 in /factory in the dependencies group #1962
Conversation
dependabot
bot
added
dependencies
So we'll need more That might be more about the removal of the AutoValue processor from the runtime classpath of Compile-Testing. |
|
There turns out to be at least two more errors after those. The first is clearly solvable by adding a missing dep: The second is likely similar but not as immediately obvious: |
|
For the latter error, I tried: --- a/factory/src/it/functional/pom.xml
+++ b/factory/src/it/functional/pom.xml
@@ -24,6 +24,11 @@
<version>HEAD-SNAPSHOT</version>
<name>Auto-Value Functional Integration Test</name>
<dependencies>
+ <dependency>
+ <groupId>com.google.auto.value</groupId>
+ <artifactId>auto-value</artifactId>
+ <version>@project.version@</version>
+ </dependency>
<dependency>
<groupId>com.google.auto.factory</groupId>
<artifactId>auto-factory</artifactId>But: I'm testing with the command from the GitHub CI config: mvn -B dependency:go-offline test clean -U --quiet --fail-never -DskipTests=true -f build-pom.xml; mvn -B verify -U --fail-at-end -Dsource.skip=true -Dmaven.javadoc.skip=true -f build-pom.xmlSo I would have hoped that that first run would have installed whatever we might need for the second run, as apparently it's done for the AutoFactory dep that we use from these same functional tests. I do seem to recall that that first run always fails, but maybe now it's failing earlier for additional missing deps. I'll try adding some deps there. Here's the failure with the Here's the failure before those changes: It's not clear to me whether that change in errors is what makes the difference or not. |
|
If I remove But now I'm seeing the same output from that command both before and after (aside from things like timings and the ordering of dependency resolution, which may or may not be relevant). I'm not sure if the difference in errors I was seeing was nondeterministic or the result of some local change that I unwittingly made. |
|
I diffed the full output from both commands. Here's the first difference that I'm seeing in the builds after my changes: That prevents us from seeing some other errors in I'm wondering if the AutoValue functional tests have never run against the head version of AutoValue but instead against whatever version was transitively pulled in through (One question is how much we need the functional tests. I'm assuming that we're running something similar inside Google under Bazel, but I haven't checked. Of course, there is likely also value in testing behavior under Maven, including perhaps testing the Maven configuration that we recommend in our documentation.) In an attempt to make mvn -B clean dependency:go-offline install -U -f value/processor ; mvn -B dependency:go-offline test -U --fail-never -DskipTests=true -f build-pom.xml; mvn -B verify -U --fail-at-end -Dsource.skip=true -Dmaven.javadoc.skip=true -f build-pom.xmlAnother thing: I noticed that Hmm: But while the error is reported for |
|
Adding a Nor does a non-
|
...but I do see factory/target/it-repo/com/google/auto/value/auto-value/1.11.0/, so it's getting there somehow. This probably takes us back to the previous sentence:
Oh, so my mistake is probably that I have the |
|
I am sorry to say that the AutoValue tests are probably still not run, though they are compiled. |
|
Thanks, I'll at least be a little more willing to consider giving up at some point :) The version change in (It's highly possible that I was at that point before but then messed it up by adding the bad |
|
Oh, maybe that part has all been about https://bugs.openjdk.org/browse/JDK-8321319, since I didn't learn my lesson from google/gson#2892 and use JDK 21 instead of 24? ...yep. OK, everything is passing, so now I just unwind unnecessary changes until I have the minimal set. |
|
@dependabot rebase |
Bumps the dependencies group in /factory with 1 update: [com.google.testing.compile:compile-testing](https://github.com/google/compile-testing). Updates `com.google.testing.compile:compile-testing` from 0.21.0 to 0.22.0 - [Release notes](https://github.com/google/compile-testing/releases) - [Commits](google/compile-testing@v0.21.0...v0.22.0) --- updated-dependencies: - dependency-name: com.google.testing.compile:compile-testing dependency-version: 0.22.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/maven/factory/dependencies-a4f5aafed1
branch
from
7992e7a to
d1476ac
Compare
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
dependabot
bot
deleted the
dependabot/maven/factory/dependencies-a4f5aafed1
branch
Bumps the dependencies group in /factory with 1 update: com.google.testing.compile:compile-testing.
Updates
com.google.testing.compile:compile-testingfrom 0.21.0 to 0.22.0Release notes
Sourced from com.google.testing.compile:compile-testing's releases.
Commits
282618cSet version number for compile-testing to 0.22.0.ed71bbfAdd adeveloperentry, as required by Sonatype in recent years.9a21460Fix Javadoc problems under JDK 21.6d8ea27Omitauto-valuefrom runtime classpath578b79fBump the github-actions group with 2 updates0595973Don't bother to explicitly set [publishingServerId](https://central.sonatyp...52796daBump org.apache.maven.plugins:maven-javadoc-plugin from 3.11.2 to 3.11.3 in t...5c2484cRemove\<groupId>org.apache.maven.plugins\</groupId>.f74b3d0Migrate tocentral-publishing-maven-pluginand offoss-parent.18ac6a8Bump com.google.errorprone:error_prone_annotations from 2.40.0 to 2.41.0 in t...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions