Commit f74b3d0
Migrate to
I missed these files in cl/782079419 because I was looking for... maybe `maven-deploy-plugin`? I forget, but apparently I was looking for _something_ that these projects don't declare as a plugin. (They haven't need to declare the plugin because they were inheriting it from `oss-parent`.)
Then this seemed like a good time to finally migrate the rest of our projects off `oss-parent`. See previous changes like cl/350197931. I've made the same changes here.
I've marginally improved upon both the CLs I mentioned before:
- I omit `<groupId>org.apache.maven.plugins</groupId>`, since that is the default.
- I omit `<publishingServerId>central</publishingServerId>`, since that is the default.
Also, I was careful not to copy `<failOnError>false</failOnError>` from `auto/value` and `auto/factory`. We don't seem to use it in our other projects, and it wasn't part of `oss-parent`.
Also, I omitted a `maven-javadoc-plugin` entry in `guava_beta_checker`, which already configured that plugin.
I could totally believe that some part of this CL will break a release somewhere. I'm not sure we'll notice until we try to publish a release. But that would be only a lateral move from where we likely are now, since we already can't publish a release until we perform the OSSRH->Central migration.
I could also totally believe that we could do things better here. Possible examples include:
- Move at least `maven-source-plugin` and `maven-javadoc-plugin` out of the release profile and into the main configuration (similar to `maven-javadoc-plugin` in `guava_beta_checker`). Or, alternatively, remove them entirely. (But removing them might cause Maven to select whatever the latest release is, and that's not great. It might also use slightly different settings that we've chosen; I'm not sure.)
- Omit the `sonatype-nexus-snapshots` configuration from projects that we don't publish snapshots for.
- Write our own common parent POM, as we've contemplated before.
RELNOTES=n/a
PiperOrigin-RevId: 788538710central-publishing-maven-plugin and off oss-parent.1 parent 18ac6a8 commit f74b3d0
1 file changed
+7
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | 4 | | |
11 | 5 | | |
12 | 6 | | |
| |||
46 | 40 | | |
47 | 41 | | |
48 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
| |||
0 commit comments