Update emscripten config settings to conform to the official emscripten toolchain.#1330
Merged
copybara-service[bot] merged 1 commit intomasterfrom Mar 4, 2021
Merged
Update emscripten config settings to conform to the official emscripten toolchain.#1330copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
|
Replaces #1329. |
copybara-service
bot
force-pushed
the
test_360784362
branch
from
d55c45a to
c118b6e
Compare
…en toolchain. Current Bazel config settings for Emscripten are specific to TensorFlow.js's custom Emscripten toolchain, but TFJS is switching to the official toolchain in [#4769](tensorflow/tfjs#4769). The official emscripten toolchain expects `crosstool_top` to be `//emscripten_toolchain:everything`. PiperOrigin-RevId: 360787196
copybara-service
bot
force-pushed
the
test_360784362
branch
from
c118b6e to
f69ac5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update emscripten config settings to conform to the official emscripten toolchain.
Current Bazel config settings for Emscripten are specific to TensorFlow.js's custom Emscripten toolchain, but TFJS is switching to the official toolchain in #4769. The official emscripten toolchain expects
crosstool_topto be//emscripten_toolchain:everything.