Add Bazel config_settings for the official Emscripten toolchain#1329
Closed
mattsoulanille wants to merge 6 commits intogoogle:masterfrom
Closed
Add Bazel config_settings for the official Emscripten toolchain#1329mattsoulanille wants to merge 6 commits intogoogle:masterfrom
mattsoulanille wants to merge 6 commits intogoogle:masterfrom
Conversation
Using config_settings_group introduces a dependency on skylib that must be added to consuming projects' workspaces. Since the legacy tfjs config settings will eventually be removed, this seems like a better solution.
Author
|
I considered using skylib's |
Author
|
Creating this internally since copybara files need to be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Bazel config settings for Emscripten are specific to TensorFlow.js's custom Emscripten toolchain. This PR adds config_settings for the official toolchain.