Repository navigation
fix(vscode-ide-companion): track both Disposables in each activate() push #28580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
LHMQ878
wants to merge
2
commits into
google-gemini:main
from
LHMQ878:fix/track-both-disposables-in-activate
Closed
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation of
subscribedTagsdirectly accesses thetagproperty on all items incontext.subscriptions. However,ideServer.start(context)also pushes standard, untaggedDisposableobjects (orundefinedif the underlying event emitter is mocked to returnundefined) tocontext.subscriptions.Currently, these tests only pass because
ideServer.startthrows an unhandled error during test execution (due tovscode.workspace.onDidOpenTextDocumentbeing unmocked), which prevents those untagged disposables from being pushed. IfideServer.startis ever successfully executed or mocked in the future,subscribedTagswill throw aTypeError(when trying to read.tagofundefined) or includeundefinedvalues, causing the assertions to fail.Using optional chaining and filtering out non-string tags makes the test suite robust against these untagged disposables, ensuring we handle the undefined cases safely.
References
undefinedcase (e.g., by providing a default with??). Do not rely on the implementation details of the function that creates the object to always provide a value, as this can change. Code against the interface contract.