fix(vscode-ide-companion): track both Disposables in each activate() push

packages/vscode-ide-companion/src/extension.test.ts

@@ -131,6 +131,91 @@ describe('activate', () => {
     expect(vscode.workspace.onDidGrantWorkspaceTrust).toHaveBeenCalled();
   });
 
+  describe('disposable tracking', () => {
+    // Each registration returns a Disposable tagged with what produced it, so
+    // the assertions below can tell *which* Disposables reached
+    // context.subscriptions rather than merely that the registration ran.
+    //
+    // Asserting the call happened is not enough: a comma expression
+    // `(regA(), regB())` still evaluates both operands, so both mocks are
+    // called while only regB's Disposable becomes the argument to push().
+    // These tests read context.subscriptions for that reason.
+    const tagged = (tag: string) => ({ tag, dispose: vi.fn() });
+
+    beforeEach(() => {
+      vi.mocked(context.globalState.get).mockReturnValue(true);
+      vi.mocked(vscode.workspace.onDidCloseTextDocument).mockImplementation(
+        () => tagged('onDidCloseTextDocument') as never,
+      );
+      vi.mocked(
+        vscode.workspace.registerTextDocumentContentProvider,
+      ).mockImplementation(
+        () => tagged('registerTextDocumentContentProvider') as never,
+      );
+      vi.mocked(
+        vscode.workspace.onDidChangeWorkspaceFolders,
+      ).mockImplementation(
+        () => tagged('onDidChangeWorkspaceFolders') as never,
+      );
+      vi.mocked(vscode.workspace.onDidGrantWorkspaceTrust).mockImplementation(
+        () => tagged('onDidGrantWorkspaceTrust') as never,
+      );
+      vi.mocked(vscode.commands.registerCommand).mockImplementation(
+        (command: string) => tagged(`command:${command}`) as never,
+      );
+    });
+
+    // Only the stubs above carry a `tag`. IDEServer.start also pushes its own
+    // untagged Disposables onto context.subscriptions, so filter to the tagged
+    // ones rather than assuming every entry is one of ours.
+    const subscribedTags = () =>
+      context.subscriptions
+        .map((d) => (d as unknown as { tag?: unknown } | undefined)?.tag)
+        .filter((tag): tag is string => typeof tag === 'string');
+
+    it('tracks every registration made during activation', async () => {
+      await activate(context);
+
+      expect(subscribedTags()).toEqual(
+        expect.arrayContaining([
+          'onDidCloseTextDocument',
+          'registerTextDocumentContentProvider',
+          'command:gemini.diff.accept',
+          'command:gemini.diff.cancel',
+          'onDidChangeWorkspaceFolders',
+          'onDidGrantWorkspaceTrust',
+          'command:gemini-cli.runGeminiCLI',
+          'command:gemini-cli.showNotices',
+        ]),
+      );
+    });
+
+    it('tracks the gemini.diff.accept command so re-activation does not collide', async () => {
+      // Left untracked, the command stays registered after deactivation and a
+      // re-activate in the same extension host throws
+      // "command 'gemini.diff.accept' already exists".
+      await activate(context);
+
+      expect(subscribedTags()).toContain('command:gemini.diff.accept');
+    });
+
+    it('tracks the onDidChangeWorkspaceFolders listener so it stops on deactivation', async () => {
+      // Left untracked, the listener outlives the IDEServer it calls and keeps
+      // firing syncEnvVars() against a stopped server.
+      await activate(context);
+
+      expect(subscribedTags()).toContain('onDidChangeWorkspaceFolders');
+    });
+
+    it('pushes one Disposable per registration', async () => {
+      await activate(context);
+
+      const tags = subscribedTags();
+      expect(tags).toHaveLength(new Set(tags).size);
+      expect(tags).toHaveLength(8);
+    });
+  });
+
   it('should launch the Gemini CLI when the user clicks the button', async () => {
     const showInformationMessageMock = vi
       .mocked(vscode.window.showInformationMessage)

packages/vscode-ide-companion/src/extension.ts

@@ -133,7 +133,7 @@ export async function activate(context: vscode.ExtensionContext) {
       DIFF_SCHEME,
       diffContentProvider,
     ),
-    (vscode.commands.registerCommand(
+    vscode.commands.registerCommand(
       'gemini.diff.accept',
       (uri?: vscode.Uri) => {
         const docUri = uri ?? vscode.window.activeTextEditor?.document.uri;
@@ -152,7 +152,7 @@ export async function activate(context: vscode.ExtensionContext) {
           diffManager.cancelDiff(docUri);
         }
       },
-    )),
+    ),
   );
 
   ideServer = new IDEServer(log, diffManager);
@@ -174,14 +174,14 @@ export async function activate(context: vscode.ExtensionContext) {
   }
 
   context.subscriptions.push(
-    (vscode.workspace.onDidChangeWorkspaceFolders(() => {
+    vscode.workspace.onDidChangeWorkspaceFolders(() => {
       // eslint-disable-next-line @typescript-eslint/no-floating-promises
       ideServer.syncEnvVars();
     }),
     vscode.workspace.onDidGrantWorkspaceTrust(() => {
       // eslint-disable-next-line @typescript-eslint/no-floating-promises
       ideServer.syncEnvVars();
-    })),
+    }),
     vscode.commands.registerCommand('gemini-cli.runGeminiCLI', async () => {
       const workspaceFolders = vscode.workspace.workspaceFolders;
       if (!workspaceFolders || workspaceFolders.length === 0) {