We aint got zombie shields #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodboy
added
bug
goodboy
force-pushed
the
we_aint_got_zombie_shields
branch
from
585c4ee to
e662269
Compare
goodboy
force-pushed
the
we_aint_got_zombie_shields
branch
2 times, most recently
from
0811c99 to
ceae999
Compare
goodboy
commented
Jan 11, 2021
| @@ -0,0 +1,45 @@ | |||
| import trio | |||
There was a problem hiding this comment.
This is just an example that shows the hang in practice.
The problem is if we have a nursery exit before receiving a ctr-c we'll be stuck in the shielded proc.wait() and have no way for the user to trigger graceful exit...
goodboy
commented
Jan 11, 2021
| # always "hard" join sub procs: | ||
| # no actor zombies allowed | ||
| with trio.CancelScope(shield=True): | ||
| await proc.wait() | ||
| # with trio.CancelScope(shield=True): |
There was a problem hiding this comment.
The main change.
Thoughts on this very welcome.
Using `None` as the default key for a `@msg.pub` can cause conflicts if
there is more then one "taskless" (no tasks={,} passed) pub offered on
an actor... So instead use the first trio "task name" (usually just the
function name) instead thus avoiding this very hard to debug and
understand problem.
Probably should throw in a test but I'm super lazy today.
goodboy
force-pushed
the
we_aint_got_zombie_shields
branch
from
ceae999 to
9f4e497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@guilledk that thing i was talkin bout..
This definitely pertains to #145 but does not yet solve it.