Skip to content

Commit

Permalink
Don't shield proc waits
Browse files Browse the repository at this point in the history
  • Loading branch information
goodboy committed Jan 9, 2021
1 parent f0a9666 commit 0811c99
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions tractor/_spawn.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,10 +273,14 @@ async def new_proc(
# ``trio.Process.__aexit__()`` (it tears down stdio
# which will kill any waiting remote pdb trace).

# TODO: No idea how we can enforce zombie
# reaping more stringently without the shield
# we used to have below...

# always "hard" join sub procs:
# no actor zombies allowed
with trio.CancelScope(shield=True):
await proc.wait()
# with trio.CancelScope(shield=True):
await proc.wait()
else:
# `multiprocessing`
assert _ctx
Expand Down

0 comments on commit 0811c99

Please sign in to comment.