Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to example config #678

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Conversation

marwan-at-work
Copy link
Contributor

config.toml is git ignored and so the docker build will fail when merging to master.
We should default to the config.example.toml then let the user specify their own config on docker run if they want to.

@marwan-at-work marwan-at-work requested a review from a team as a code owner September 19, 2018 06:15
@codecov-io
Copy link

Codecov Report

Merging #678 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #678   +/-   ##
=======================================
  Coverage   44.24%   44.24%           
=======================================
  Files         105      105           
  Lines        3232     3232           
=======================================
  Hits         1430     1430           
  Misses       1665     1665           
  Partials      137      137

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d94c3...8f91895. Read the comment docs.

@marwan-at-work marwan-at-work merged commit b6ca414 into gomods:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants