-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capitalization for common initialisms? #156
Comments
No, we won't do this. There's a never-ending list, we'll get it wrong, and it's simpler to stick with the current mechanical translation. We don't hold machine-generated code to the same high standard as human-written code. |
But humans have to then consume and interact with this non-idiomatic machine-generated code. It's not a never ending list - just put the initialisms from Refusing to acknowledge and / or fix this defect only ensures and forces that things continue to be generated in an ugly, non-compliant way, needlessly. |
FWIW, I think Go linter should relax its rules on ID, URL etc. being capitalized. |
you can use
|
Thanks @yaronsumel , will give it a try. |
New domain object: ToCrawlEntry. Using gogo because Google's go protobuf pkg may never be go-friendly, see: golang/protobuf#156
I actually might be against this, I like that
id
maps toId
,url
maps toUrl
, etc, but there's an issue that was filed over at protocolbuffers/protobuf#1321 so it's at least worth a discussion - any thoughts on changing the generator to output capitalizations for https://github.com/golang/lint/blob/master/lint.go#L719 ?The text was updated successfully, but these errors were encountered: