-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change “ID” to “Id” in Method names #173
Comments
If we do this, @jieyu suggested renaming |
Closed with #182 |
Hello, This causes golint to fail for NodeGetId because it expects NodeGetID. Is the recommendation to ignore this error? Should we use something like this for the go generated file:
This is a snippet from: golang/protobuf#156 Thanks |
Where is golint failing, exactly? When linting your client code, or the
generated proto bindings?
…On Wed, Mar 7, 2018 at 3:47 PM, pure-yesmat ***@***.***> wrote:
Hello,
This causes golint to fail for NodeGetId because it expects NodeGetID. Is
the recommendation to ignore this error?
Should we use something like this for the go generated file:
you can use github.com/gogo/protobuf
message C {
optional int64 size = 1 [(gogoproto.customname) = "MySize"];
}
type C struct {
MySize *int64
}
This is a snippet from: golang/protobuf#156
<golang/protobuf#156>
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#173 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACPVLDaqlH9ps-Nxkbp8ZntghOreaumQks5tcEdLgaJpZM4RrlLO>
.
|
golint should NOT be linting generated-code:
https://github.com/golang/lint/blob/c72d1a524d88a66072b772f7452bd830adf57bcd/lint.go#L125
…On Wed, Mar 7, 2018 at 3:55 PM, James DeFelice ***@***.***> wrote:
Where is golint failing, exactly? When linting your client code, or the
generated proto bindings?
On Wed, Mar 7, 2018 at 3:47 PM, pure-yesmat ***@***.***>
wrote:
> Hello,
>
> This causes golint to fail for NodeGetId because it expects NodeGetID. Is
> the recommendation to ignore this error?
>
> Should we use something like this for the go generated file:
>
> you can use github.com/gogo/protobuf
>
> message C {
> optional int64 size = 1 [(gogoproto.customname) = "MySize"];
> }
> type C struct {
> MySize *int64
> }
>
> This is a snippet from: golang/protobuf#156
> <golang/protobuf#156>
>
> Thanks
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#173 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACPVLDaqlH9ps-Nxkbp8ZntghOreaumQks5tcEdLgaJpZM4RrlLO>
> .
>
|
The implementation of the NodeServer interface. Example: |
Ping :) |
So, in your code... |
You're saying in order to implement the CSI spec you have to write Go code by hand that does not pass golint? |
I think you'll want to wait for and weigh in on golang/protobuf#555. |
Recommendation from a gRPC author after review of CSI API: follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case style guide
Specifically,
GetNodeID(...)
should beGetNodeId(...)
The text was updated successfully, but these errors were encountered: