This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
verify: Exclude symlinks from hash digests #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
force-pushed
the
symlink-noverify
branch
from
23ccab6 to
2048fea
Compare
As we're moving in the direction of excluding symlinks entirely from dependencies (hallelujah!), it's preferable to have the initial release of vendor verification exclude symlinks from hash digests entirely. For the most part, people shouldn't notice it, and we won't be forced to bump the hash version when we stop writing out symlinks (though we may bump it anyway).
sdboyer
force-pushed
the
symlink-noverify
branch
from
2048fea to
a6ab319
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Completely exclude symlinks from the file tree hashing algorithm behind vendor verification. We never traversed them, but this change means we don't even incorporate their target path into the hash.
As we're moving in the direction of excluding symlinks entirely from dependencies (hallelujah!), it's preferable to have the initial release of vendor verification exclude symlinks from hash digests entirely. For the most part, people shouldn't notice it, and we won't be forced to bump the hash version when we stop writing out symlinks (though we may bump it anyway).
What should your reviewer look out for in this PR?
Unintended consequences of this, mostly.
Do you need help or clarification on anything?
Nope.
Which issue(s) does this PR fix?
fixes #1931