Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Ignore symlinks in tree hasher #1931

Closed
sdboyer opened this issue Jul 11, 2018 · 1 comment · Fixed by #1960
Closed

Ignore symlinks in tree hasher #1931

sdboyer opened this issue Jul 11, 2018 · 1 comment · Fixed by #1960
Assignees
Milestone

Comments

@sdboyer
Copy link
Member

sdboyer commented Jul 11, 2018

vgo has set the (omg, wonderful) precedent that we're just gonna discard symlinks from well-formed dependencies. Just, straight up, ignore them. (This is one of the things i really like about vgo).

We'll ride that train, and ignore symlinks in the tree hasher that @karrick wrote, but we only just finally started using in #1912. That'll simplify the code, as well - we can get rid of the custom walker and just use Filepath.Walk().

@sdboyer sdboyer added this to the v0.5.0 milestone Jul 11, 2018
@sdboyer sdboyer self-assigned this Jul 11, 2018
@karrick
Copy link
Contributor

karrick commented Aug 22, 2018

@sdboyer, I got pulled away from this project pretty much one year ago due to mounting work pressures.

That being said, I can update it to use godirwalk, while ignoring symlinks, and also be ~ 2x speed of filepath.Walk...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants