gps: pkgtree: fix and simplify CreateIgnorePrefixTree #1266
Conversation
|
|
||
| // Create a sorted list of all the ignores to have a proper order in | ||
| // ignores parsing. | ||
| sortedIgnores := make([]string, len(ig)) |
There was a problem hiding this comment.
I think the intention here was make([]string, 0, len(ig)), but I think that optimization no longer makes sense after moving the filtering up.
There was a problem hiding this comment.
The bug here was that making with the length only initialized sortedIgnores with len(ig) empty strings, which made append grow the slice anyways (up to 2*len(ig)), slowing down the sort and second loop, but the extra empty entries would end up being filtered out.
| if i == "*" { | ||
| continue | ||
| // Skip global and non-recursive ignore. | ||
| if len(k) > 1 && k[len(k)-1] == '*' { |
There was a problem hiding this comment.
Filtering on the first loop reduces the slice length for sorting and the second loop, and enables an earlier exit path.
|
i've got a PR coming up that removes this func entirely in favor of a new approach, so we can not worry about these bits 😄 |
What does this do / why do we need it?
This PR fixes a small inefficiency bug in
pkgtree.CreateIgnorePrefixTree, and further optimizes and simplifies some of the surrounding code. Discovered while investigating #1264, but not expected to resolve it.