-
Notifications
You must be signed in to change notification settings - Fork 1k
Wildcard ignore not working #1264
Comments
This looks correct behavior to me. Ignoring @sdboyer correct me? |
I've been wrestling with that question recently - I'm not sure what my original intent was. I need to revisit the docs/spec I originally wrote and check over the existing system for sanity in this regard. |
Somewhat related to this, is it possible to instruct dep to ignore all dependencies that come from a local package? In my specific case inside my repo, I have a directory called plugins/, which contains the source codes for several go plugins, each of which has its own vendor/ directory that contains all of its dependencies. The plugin dependencies are therefore not needed inside the main vendor/ directory, but they still appear there. I tried adding several variations of the ignored parameter inside the Gopkg.toml with no success. I tried: ignored = ["./plugins/*", "./plugins*", "bitbucket.org/<user>/<repo>/plugins*"] |
we definitely need clearer docs on the syntax here. the expectation, as with real import paths in a project that point to other packages within that project, is that you provide the full import path - not a relative one. that should have the desired effect. |
I tried that as well, but didn't work. Is it possible that dep can't ignore local packages? I have the repo https://github.com/e-nikolov/my-real-repo/ that demonstrates what I do. It has this in ignored: ignored = ["github.com/e-nikolov/my-real-repo/plugins*", "github.com/e-nikolov/my-fake-repo/plugins*"] Where my-real-repo is the repo itself and my-fake-repo is a non-existent repo. When I run |
@e-nikolov yes, ignores from current project aren't added to I cloned your repo and ran NOTE that ignore is just ignoring static code analysis of the specified packages, not ignoring to vendor them. Hope this helps :) |
Which revision of dep do you use? When I run dep ensure here, it doesn't remove chi from the main vendor. Edit: It works with v0.3.2. I hadn't realized that wildcard ignore is a new feature. |
What version of
dep
are you using (dep version
)?v0.3.1-122-g98f625e
What
dep
command did you run?dep hash-inputs
dep ensure -v
What did you expect to see?
dep status
What did you see instead?
dep status
The text was updated successfully, but these errors were encountered: