Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

docker/docker: panic #116

Closed
jessfraz opened this issue Jan 20, 2017 · 8 comments · Fixed by #123
Closed

docker/docker: panic #116

jessfraz opened this issue Jan 20, 2017 · 8 comments · Fixed by #123
Labels

Comments

@jessfraz
Copy link
Contributor

running init on docker/docker after nuking vendor gives:

| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | try github.com/davecgh/[email protected]
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ✓ select github.com/davecgh/[email protected] w/1 pkgs
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ? attempt github.com/docker/swarmkit with 8 pkgs; 11 versions to try
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | try github.com/docker/[email protected]
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ✗ github.com/docker/swarmkit at v1.12.0 has problem subpkg(s):
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |     github.com/docker/swarmkit/agent/secrets is missing; required by (root). github.com/docker/swarmkit/manager/encryption is missing; required by (root).    github.com/docker/swarmkit/node is missing; required by (root). github.com/docker/swarmkit/template is missing; required by (root).
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | try github.com/docker/[email protected]
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ✗ github.com/docker/swarmkit at v1.12.0 has problem subpkg(s):
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |     github.com/docker/swarmkit/agent/secrets is missing; required by (root). github.com/docker/swarmkit/manager/encryption is missing; required by (root).    github.com/docker/swarmkit/node is missing; required by (root). github.com/docker/swarmkit/template is missing; required by (root).
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | try github.com/docker/swarmkit@master
panic: should never call ListPackages on root project

goroutine 1 [running]:
github.com/golang/dep/vendor/github.com/sdboyer/gps.(*bridge).ListPackages(0xc4203318c0, 0xc42002207c, 0x18, 0x0, 0x0, 0xa06d60, 0xc4201a9100, 0x0, 0x0, 0xa06d60, ...)
        /usr/local/google/home/jessfraz/.go/src/github.com/golang/dep/vendor/github.com/sdboyer/gps/bridge.go:287 +0x219
github.com/golang/dep/vendor/github.com/sdboyer/gps.(*solver).checkPackageImportsFromDepExist(0xc4204dee10, 0xc420180d80, 0x1a, 0x0, 0x0, 0xa06ee0, 0xc42038c620, 0xc4204aa200, 0x8, 0x8, ...)
        /usr/local/google/home/jessfraz/.go/src/github.com/golang/dep/vendor/github.com/sdboyer/gps/satisfy.go:235 +0x11d
github.com/golang/dep/vendor/github.com/sdboyer/gps.(*solver).check(0xc4204dee10, 0xc420180d80, 0x1a, 0x0, 0x0, 0xa06ee0, 0xc42038c620, 0xc4204aa200, 0x8, 0x8, ...)
        /usr/local/google/home/jessfraz/.go/src/github.com/golang/dep/vendor/github.com/sdboyer/gps/satisfy.go:68 +0x4de
github.com/golang/dep/vendor/github.com/sdboyer/gps.(*solver).findValidVersion(0xc4204dee10, 0xc4206b9720, 0xc4204aa200, 0x8, 0x8, 0x0, 0xc4204aa200)
        /usr/local/google/home/jessfraz/.go/src/github.com/golang/dep/vendor/github.com/sdboyer/gps/solver.go:754 +0x2d5
github.com/golang/dep/vendor/github.com/sdboyer/gps.(*solver).createVersionQueue(0xc4204dee10, 0xc420180d80, 0x1a, 0x0, 0x0, 0xc4204aa200, 0x8, 0x8, 0x0, 0x0, ...)
        /usr/local/google/home/jessfraz/.go/src/github.com/golang/dep/vendor/github.com/sdboyer/gps/solver.go:727 +0xae2
github.com/golang/dep/vendor/github.com/sdboyer/gps.(*solver).solve(0xc4204dee10, 0x0, 0x0, 0xc420234bd0)
        /usr/local/google/home/jessfraz/.go/src/github.com/golang/dep/vendor/github.com/sdboyer/gps/solver.go:366 +0x471
github.com/golang/dep/vendor/github.com/sdboyer/gps.(*solver).Solve(0xc4204dee10, 0x40, 0xc42002207c, 0x18, 0xc42013f020)
        /usr/local/google/home/jessfraz/.go/src/github.com/golang/dep/vendor/github.com/sdboyer/gps/solver.go:317 +0x8e
main.(*initCommand).Run(0xa502d0, 0xc420010410, 0x0, 0x0, 0x0, 0x0)
        /usr/local/google/home/jessfraz/.go/src/github.com/golang/dep/init.go:152 +0xfc6
main.main()
        /usr/local/google/home/jessfraz/.go/src/github.com/golang/dep/main.go:99 +0x617
@sdboyer
Copy link
Member

sdboyer commented Jan 20, 2017

mmm yeah when we ran into the similar case on windows i was thinking one like this might also exist - where a package in a dep imports a package in the current project. i don't have an explicit test case for it (obviously), but assuming the issue is what i think it is, the fix is straightforward.

@jessfraz
Copy link
Contributor Author

this is related to #114

@jessfraz jessfraz added the bug label Jan 23, 2017
@jessfraz
Copy link
Contributor Author

@sdboyer
Copy link
Member

sdboyer commented Jan 24, 2017

yep, OK. i'm pretty sure i know exactly what this is. if i do, then both the fix and a test case for it should be easy.

@jessfraz
Copy link
Contributor Author

jessfraz commented Jan 24, 2017 via email

@sdboyer
Copy link
Member

sdboyer commented Jan 24, 2017

but just project-level cyclic, not package-level, right?

@jessfraz
Copy link
Contributor Author

jessfraz commented Jan 24, 2017 via email

@sdboyer
Copy link
Member

sdboyer commented Jan 24, 2017

sdboyer/gps#151

jessfraz pushed a commit that referenced this issue Jan 24, 2017
This fixes an issue where project cycles involving the root project were
erroneously rejected. It should fix #116.
zbintliff added a commit to zbintliff/dep that referenced this issue Mar 3, 2017
This fixes an issue where project cycles involving the root project were
erroneously rejected. It should fix golang#116.
ibrasho pushed a commit to ibrasho-forks/dep that referenced this issue May 10, 2017
This fixes an issue where project cycles involving the root project were
erroneously rejected. It should fix golang#116.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants