Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsonpb option to disable HTML scaping #694

Closed
wants to merge 1 commit into from

Conversation

@johanbrandhorst
Copy link
Member

Hm, I can see that this wasn't merged upstream, so should we really merge this here?

@antoniomo
Copy link
Author

I guess it depends on the desired solution for #484?

As an alternative it can live as an external package, as a gogo/protobuf/jsonpb replacement. The caveat is that it makes it harder to use with other packages that just go "here" for the gogo jsonpb functionality.

@johanbrandhorst
Copy link
Member

I guess it depends on the desired solution for #484?

As an alternative it can live as an external package, as a gogo/protobuf/jsonpb replacement. The caveat is that it makes it harder to use with other packages that just go "here" for the gogo jsonpb functionality.

Thanks for the explanation. I'm not super experienced with managing this repo, so I'm going to err on the side of caution and reject this PR for now. Could you update the issue with link to your own solution for those looking for an answer? Thanks and sorry for the silence on this PR and inconvenience.

@antoniomo
Copy link
Author

No problem, that's understandable. I'll keep my fork with the branch so other's can use this PR as reference workaround, and perhaps keep a standalone jsonpb package with just the jsonpb code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants