-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable HTML Escaping in jsonpb? #484
Comments
I agree. When exposing an external web service, many times you can't make any guarantee about who is consuming the service and their ability to handle unmarshalling data encoded this way. |
If gogo/protobuf messages implement the upcoming v2 message interface, the gogo/protobuf project wouldn't have to maintain their own version of jsonpb. In my opinion it is healthier for the Go protobuf ecosystem if the v2 The currently implementation of v2 |
I should also note that the escaped HTML characters is still fully compliant with RFC 7159, so this is still indicative of a bug with those clients. |
Helps fixing: - gogo#484 - grpc-ecosystem/grpc-gateway#566 via https://github.com/gogo/gateway Upstream issue: golang/protobuf#409 Original upstream patch by Paul Nichols (@pauln) here: golang/protobuf#409
For those looking for a solution, a possible workaround is #694. I'll also maintain this fork for use with the grpc-gateway: https://github.com/antoniomo/gateway |
Opening this for discussion.
Here is the golang/protobuf issue for the same topic golang/protobuf#407
Should gogo enable this?
Would be really nice to have.
The text was updated successfully, but these errors were encountered: