Skip to content

chore: translte zh comment to en#4591

Merged
gqcn merged 5 commits intogogf:masterfrom
yuluo-yx:0106-yuluo/feat
Jan 9, 2026
Merged

chore: translte zh comment to en#4591
gqcn merged 5 commits intogogf:masterfrom
yuluo-yx:0106-yuluo/feat

Conversation

@yuluo-yx
Copy link
Contributor

@yuluo-yx yuluo-yx commented Jan 6, 2026

AS TITLE

Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Copilot AI review requested due to automatic review settings January 6, 2026 15:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request translates Chinese comments to English across validation utility files to improve code accessibility for international developers.

Key Changes:

  • Translated documentation comments in validation rule implementations from Chinese to English
  • Updated test case expected outputs to use English error messages instead of Chinese
  • Converted code example comments to English for better international comprehension

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
util/gvalid/internal/builtin/builtin_resident_id.go Translated Chinese comments explaining China resident ID validation pattern to English
util/gvalid/internal/builtin/builtin_phone_loose.go Converted Chinese documentation for loose phone number validation rule to English
util/gvalid/gvalid_z_example_test.go Updated expected test outputs from Chinese error messages to English equivalents
util/gvalid/gvalid.go Translated example comment demonstrating tag value parsing from Chinese to English

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 6, 2026 15:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

yuluo-yx and others added 2 commits January 7, 2026 22:13
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Copilot AI review requested due to automatic review settings January 7, 2026 14:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hailaz hailaz added the discuss We need discuss to make decision. label Jan 9, 2026
@hailaz hailaz requested a review from gqcn January 9, 2026 02:14
@gqcn gqcn merged commit 40f4d9f into gogf:master Jan 9, 2026
18 checks passed
@yuluo-yx yuluo-yx deleted the 0106-yuluo/feat branch January 9, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discuss We need discuss to make decision.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants