Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration pull requests not being processed, months old (Jan) #194

Open
grnassar opened this issue Apr 27, 2022 · 2 comments
Open

Integration pull requests not being processed, months old (Jan) #194

grnassar opened this issue Apr 27, 2022 · 2 comments

Comments

@grnassar
Copy link

grnassar commented Apr 27, 2022

Problem
Uplay integration PR pending since Jan 23, no action taken:
https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/pulls

Rockstar integration PR pending since Jan 6, no action taken:
https://github.com/FriendsOfGalaxy/galaxy-integration-rockstar/pulls

Humble Bundle integration new release available a month ago (Mar 28), FriendsOfGalaxyBot failed to identify update (edit: seems the GitHub Actions workflow for updating was disabled due to inactivity on the FriendsOfGalaxy repo for >60 days, which is concerning - https://github.com/FriendsOfGalaxy/galaxy-integration-humble/actions/workflows/sync.yml)

Solution
1a) Process/accept two above PRs and any other pending community integration PRs, AND/OR
1b) Configure community integration PRs from their upstream dev to auto-approve after 1mo or 2w or such in case it hasn't been looked at -- should be enough time for upstream to pull a bugged integration
2) (optional) If FriendsOfGalaxyBot issue is indeed due to bug as guessed above, fix bug so 0.10.0 > 0.9.5

Alternatives
Included in Solution

grnassar added a commit to grnassar/gog-galaxy-plugin-downloader that referenced this issue May 11, 2022
First of a few changes moving from FriendsOfGalaxy repos to their upstreams (which also will more accurately reflect links in the Mixaill/awesome-gog-galaxy "Github-official" list).  FoG repositories are no longer updating, and haven't been since early January.  See gogcom/galaxy-integrations-python-api#194  This has broken a number of plugins, including this one.
@tarrouye
Copy link

Probably whoever was leading this project has left GOG... It's a shame, Galaxy 2.0 with all the integrations has so much potential 🥲

@abelcheung
Copy link

@tarrouye It's more like certainly rather than probably, given the fact that python API maintainer has already stated his/her status since last year. Until CDPR decides this integration is important enough to warrant allocating another dev, things are extremely unlikely to change for now, instead of some fanatic in other repo who thinks bumping approval count would automagically get things fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants